CI Use hashes to pin most Github actions #29206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
commented
Jun 6, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| name: Run CircleCI artifacts redirector | |||
| steps: | |||
| - name: GitHub Action step | |||
| uses: larsoner/circleci-artifacts-redirector-action@master | |||
| uses: larsoner/circleci-artifacts-redirector-action@4e13a10d89177f4bfc8007a7064bdbeda848d8d1 # v1.0.0 | |||
There was a problem hiding this comment.
I figure I would use the latest version rather than master here
|
Apparently this is was a bit too naive, see #29203 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the Dependabot PR #29203 to update commit hashes with human readable comment instead of only major version.
I added the
major.minor.patchmanually based on each project release/tags. After that I used https://github.com/mheap/pin-github-action to transform into commit hashes. I double-checked everything looked allright:Side comment: there are still 3 actions without commit hash because I am not quite sure how to do it. They have many actions in the same repo: https://github.com/github/codeql-action