Skip to content

add array API support for d2_tweedie_score #29207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2024
Merged

add array API support for d2_tweedie_score #29207

merged 4 commits into from
Jun 7, 2024

Conversation

EmilyXinyi
Copy link
Contributor

Reference Issues/PRs

towards #26024

What does this implement/fix? Explain your changes.

add array API support for d2_tweedie_score

Any other comments?

I still need to update the documentation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: dd3704a. Link to the linter CI: here

ogrisel
ogrisel reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Apart from the formatting issue reported by the automated linter, this looks good to me.

Let me start a CUDA GPU CI run here:

If this is green and once the linting problem is fixed, +1 for merge on my end.

EDIT: CUDA CI is green.

ogrisel
ogrisel approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @EmilyXinyi and welcome to the scikit-learn project!

@ogrisel ogrisel added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jun 7, 2024
@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2024

/cc @OmarManzoor

OmarManzoor
OmarManzoor approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @EmilyXinyi

@OmarManzoor OmarManzoor merged commit e4362e5 into scikit-learn:main Jun 7, 2024
31 checks passed
@ogrisel ogrisel mentioned this pull request Jun 7, 2024
Open
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
@EmilyXinyi EmilyXinyi deleted the array_API_d2_tweedie_score branch August 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
Array API module:metrics Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
Array API
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilyXinyi @ogrisel @OmarManzoor