CI Use development Cython wheel rather than building from source #29223
Conversation
build_tools/azure/install.sh
Outdated
| @@ -55,7 +55,7 @@ pre_python_environment_install() { | |||
| check_packages_dev_version() { | |||
| for package in $@; do | |||
| package_version=$(python -c "import $package; print($package.__version__)") | |||
| if ! [[ $package_version =~ "dev" ]]; then | |||
| if [[ $package_version =~ "\.[0-9]+$" ]]; then | |||
There was a problem hiding this comment.
I don't understand the logic here. Shouldn't \. be under the scope of the + operator?
Also why a $ without an ^?
I would have expected:
| if [[ $package_version =~ "\.[0-9]+$" ]]; then | |
| if [[ $package_version =~ "^[\.0-9]+$" ]]; then |
I confirmed it with https://regex101.com/r/O54PWi/1
There was a problem hiding this comment.
This was only checking the last part after the dot, dot included, i.e. .0a0 in 3.1.0a0. I agree that your regex is more explicit. I'll push a fix doing this with the simplification that you can use . instead of \. inside [].
Side-comment: the reason that this check needed to change is that Cython development version does not have dev in its name and is actually 3.1.0a0.
|
Apart from the regexp discussion above, this LGTM. I checked the CI logs for the |
|
Please re-trigger |
|
The free-threaded and scipy-dev CI build are green and I double-checked that Cython development version was used in both builds, merging! |
Cython has a development wheel in scientific-python-nightly-wheels as mentioned by @betatim in #29191 (comment)