Skip to content

MAINT Directly cimport stack from Cython #29228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2024
Merged

MAINT Directly cimport stack from Cython #29228

merged 2 commits into from
Jun 10, 2024
+1 −9

Conversation

adam2392
Copy link
Member

@adam2392 adam2392 commented Jun 10, 2024 •
edited
Loading

Reference Issues/PRs

n/a

What does this implement/fix? Explain your changes.

  • directly imports the stack from Cython 3.0+

Any other comments?

Noticed this when I was hacking some of the Cython internal tree code. This should be an extremely quick review.

@adam2392
Fix cython main
06e6512 
Signed-off-by: Adam Li <adam2392@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 37bf2b9. Link to the linter CI: here

adrinjalali
adrinjalali approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@adam2392 adam2392 mentioned this pull request Jun 10, 2024
Open
@adam2392
Copy link
Member Author

The CIs do not pass, but upon glance, they do not look related? Perhaps some issue with pulling some files from an online API?

https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=67450&view=logs&j=f71949a9-f9d9-549e-cf45-2e99c7b412d1&t=11e6ea3b-68dc-5625-4d2d-1b8393fea9ee&l=149

@adrinjalali adrinjalali merged commit 8132683 into scikit-learn:main Jun 10, 2024
30 checks passed
@adam2392 adam2392 deleted the cython branch June 10, 2024 22:14
@lesteve
Copy link
Member

lesteve commented Jun 11, 2024

The CIs do not pass, but upon glance, they do not look related? Perhaps some issue with pulling some files from an online API?

For the record, this looks like fetch_california_housing HTTP 403, I added #28297 (comment) to mention it in the original issue.

@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
cython module:tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam2392 @lesteve @adrinjalali