Skip to content

Doc add plot outlier detection wine to docs #29237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 6, 2024
Merged

Doc add plot outlier detection wine to docs #29237

merged 9 commits into from
Aug 6, 2024

Conversation

nbrown-ScottLogic
Copy link
Contributor

Reference Issues/PRs

Issue #26927

What does this implement/fix? Explain your changes.

This PR adds an example of robust covariance estimation for use in outlier detection

Related Example files:

plot_outlier_detection_wine.py

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 67e87df. Link to the linter CI: here

adrinjalali
adrinjalali reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

doc/modules/outlier_detection.rst Outdated
Comment on lines 249 to 250
* See :ref:`sphx_glr_auto_examples_applications_plot_outlier_detection_wine.py` for an example of robust covariance estimation
on a real data set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please wrap the line to <88 characters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By wrap to <88 do you mean reduce the number of characters to 87 or move everything onto the same line?

@nbrown-ScottLogic @adrinjalali
Fix to line length
adb60d8 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@adrinjalali
Copy link
Member

Build is failing because:

/home/circleci/project/doc/modules/outlier_detection.rst:250: WARNING: Bullet list ends without a blank line; unexpected unindent.

Try adding another newline after the bullet list and see if it fixes the issue.

@nbrown-ScottLogic
Copy link
Contributor Author

Build is failing because:

/home/circleci/project/doc/modules/outlier_detection.rst:250: WARNING: Bullet list ends without a blank line; unexpected unindent.

Try adding another newline after the bullet list and see if it fixes the issue.

Made a change now, let me know if its sorted it

@adrinjalali
Copy link
Member

The CI still fails. Try merging with latest main, and play around till the issue is fixed and ping me then :)

@marenwestermann
Copy link
Member

@adrinjalali I think this can be merged now, right?

@adrinjalali
Copy link
Member

Thanks for the reminder @marenwestermann , and thanks for the PR @nbrown-ScottLogic

@adrinjalali adrinjalali enabled auto-merge (squash) August 6, 2024 13:53
@adrinjalali adrinjalali merged commit 5600faa into scikit-learn:main Aug 6, 2024
30 checks passed
@adrinjalali adrinjalali mentioned this pull request Aug 6, 2024
Closed
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
@nbrown-ScottLogic @adrinjalali @MarcBresson
DOC add link to plot outlier detection wine to docs (scikit-learn#29237)
2f11c0d 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
@nbrown-ScottLogic @adrinjalali @glemaitre
DOC add link to plot outlier detection wine to docs (scikit-learn#29237)
694c1d4 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit that referenced this pull request Sep 11, 2024
@nbrown-ScottLogic @adrinjalali @glemaitre
DOC add link to plot outlier detection wine to docs (#29237)
64a264e 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbrown-ScottLogic @adrinjalali @marenwestermann