array API support for mean_gamma_deviance #29239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jun 12, 2024
betatim
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #26024
What does this implement/fix? Explain your changes.
add array API support for
mean_gamma_devianceAny other comments?
mean_gamma_devianceis a special case ofmean_tweedie_deviancewhere power=2 and both y_pred and y_true must be strictly positive. For this reason I have added the test casecheck_array_api_regression_metric_gamma(because the y_true incheck_array_api_regression_metriccontains 0 and I didn't want to change a test that is so widely used). I am not sure if this is the best way to approach this, so if there are any suggestions on how to do this better I would love to know. Thanks!!