Skip to content

[MRG] Fix typo in error message when attempting to cluster with more clusters than items #29242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jcainey
Copy link
Contributor

@jcainey jcainey commented Jun 12, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Fixes a typo in an error message.

Any other comments?

Copy link

github-actions bot commented Jun 12, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8ee1406. Link to the linter CI: here

@jcainey jcainey changed the title Fix typo in error message when attempting to cluster with more clusters than items [MRG] Fix typo in error message when attempting to cluster with more clusters than items Jun 12, 2024
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jcainey

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
@lesteve lesteve enabled auto-merge (squash) June 14, 2024 11:48
@lesteve
Copy link
Member

lesteve commented Jun 14, 2024

Thanks @jcainey I added @jeremiedbb's suggestion and set auto-merge, this PR will be merged automatically when CI is green.

@lesteve lesteve merged commit dc1cad2 into scikit-learn:main Jun 14, 2024
28 checks passed
@jcainey jcainey deleted the fix_typo branch June 14, 2024 14:09
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
…clusters than items (scikit-learn#29242)

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
…clusters than items (scikit-learn#29242)

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb added a commit that referenced this pull request Jul 2, 2024
…clusters than items (#29242)

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants