Skip to content

DOC add example with set_params. #29243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2024
Merged

DOC add example with set_params. #29243

merged 5 commits into from
Jun 13, 2024

Conversation

m-maggi
Copy link
Contributor

@m-maggi m-maggi commented Jun 12, 2024

Reference Issues/PRs

Attempt to fix #29101

What does this implement/fix? Explain your changes.

Show with an example that after calling sklearn.pipeline.Pipeline.set_params the set_output of the transformer is "gone".

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0d2cbae. Link to the linter CI: here

@m-maggi m-maggi marked this pull request as draft June 12, 2024 19:59
@m-maggi m-maggi marked this pull request as ready for review June 13, 2024 06:01
ArturoAmorQ
ArturoAmorQ approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @m-maggi! Just a small suggestion but otherwise LGTM :)

m-maggi and others added 2 commits June 13, 2024 12:58
@m-maggi @ArturoAmorQ
DOC Update examples/miscellaneous/plot_set_output.py
f0119a8 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@m-maggi
DOC Linting
d88c96c
@ArturoAmorQ
Copy link
Member

I took the liberty to push a last tweak. Thanks again for your time @m-maggi. Merging!

@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) June 13, 2024 12:38
@ArturoAmorQ ArturoAmorQ merged commit 955ec74 into scikit-learn:main Jun 13, 2024
28 checks passed
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@m-maggi @jeremiedbb
DOC add example with set_params. (scikit-learn#29243)
72e9a69
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@m-maggi @jeremiedbb
DOC add example with set_params. (scikit-learn#29243)
df38ec2
jeremiedbb pushed a commit that referenced this pull request Jul 2, 2024
@m-maggi @jeremiedbb
DOC add example with set_params. (#29243)
15202ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a Pipeline step is changed via set_params, the set_output state is cleared
2 participants
@m-maggi @ArturoAmorQ