✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: cc66a60. Link to the linter CI: here}

I think that if we want to do this we need automated tools otherwise it will quickly become inconsistent. Such tools already exists as explained in #20813 (comment). Imo we should really consider setting up a linter and a pre-commit hook.

@jeremiedbb yes, we use that in fairlearn as well. ruff/flake have these linter plugins and easy to configure. Happy to do that in a separate PR as well.

A small question because I could not find quickly in the original discussion: did we discuss the option to centralize everything in the LICENSE file similarly to what scikit-image is doing: https://github.com/scikit-image/scikit-image/blob/main/LICENSE.txt

I'm just wondering what make it easier in terms of maintenance and being up to date in that regards.

To me the advantage of having it in every file is to make it easy for third party libs to vendor/reuse parts of scikit-learn because they just have to take the file.

To me the advantage of having it in every file is to make it easy for third party libs to vendor/reuse parts of scikit-learn because they just have to take the file.

Good point.

So should we merge this? This should be the least controversial one I think.