Skip to content

ENH Array API for chi2_kernel #29267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2024
Merged

ENH Array API for chi2_kernel #29267

merged 3 commits into from
Jun 20, 2024

Conversation

Tialo
Copy link
Contributor

@Tialo Tialo commented Jun 14, 2024

Reference Issues/PRs

Towards #26024

What does this implement/fix? Explain your changes.

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: aa8089d. Link to the linter CI: here

EdAbati
EdAbati reviewed Jun 15, 2024
View reviewed changes
Copy link
Contributor

@EdAbati EdAbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CUDA tests pass. For mps we should merge #29256 first.

It looks good to me, just left a small comment :)

@Tialo @EdAbati
Update sklearn/metrics/pairwise.py
aa8089d 
Co-authored-by: Edoardo Abati <29585319+EdAbati@users.noreply.github.com>
EdAbati
EdAbati approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@EdAbati EdAbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it counts, but LGTM :)

@EmilyXinyi
Copy link
Contributor

Not sure if it counter either, but also LGTM :)

ogrisel
ogrisel approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks all for the PR, reviews and making sure that the tests pass on CUDA.

@ogrisel ogrisel merged commit fa65654 into scikit-learn:main Jun 20, 2024
30 checks passed
@Tialo Tialo deleted the array-api/chi2_kernel branch June 20, 2024 10:00
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
@OmarManzoor OmarManzoor mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@EdAbati EdAbati EdAbati approved these changes

@EmilyXinyi EmilyXinyi EmilyXinyi approved these changes

Assignees
No one assigned
Labels
Array API module:metrics
Projects
Array API
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tialo @EmilyXinyi @ogrisel @EdAbati