TST use global_random_seed in sklearn/decomposition/tests/test_factor_analysis.py #29272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marenwestermann
commented
Jun 16, 2024
| @@ -57,7 +57,7 @@ def test_factor_analysis(): | |||
| # Model Covariance | |||
| mcov = fa.get_covariance() | |||
| diff = np.sum(np.abs(scov - mcov)) / W.size | |||
| assert diff < 0.1, "Mean absolute difference is %f" % diff | |||
| assert diff < 0.2, "Mean absolute difference is %f" % diff | |||
There was a problem hiding this comment.
When I added the global_random_seed fixture I got the following test failures:
FAILED sklearn/decomposition/tests/test_factor_analysis.py::test_factor_analysis[16] - AssertionError: Mean absolute difference is 0.170675
FAILED sklearn/decomposition/tests/test_factor_analysis.py::test_factor_analysis[38] - AssertionError: Mean absolute difference is 0.130926
FAILED sklearn/decomposition/tests/test_factor_analysis.py::test_factor_analysis[96] - AssertionError: Mean absolute difference is 0.134258
By increasing the threshold the failures are fixed. 0.2 looks acceptable to me but let me know if you disagree.
|
Thanks for the PR. Can you please run for all the seeds on the CI? |
|
I triggered the CI twice with the same results. The failures seem to be related to #29278 |
|
Just in case (probably overcautious but oh well 😅) I pushed an empty commit to trigger a full CI. For completeness, you could imagine a very edge case scenario where the last commit has a green CI because it is running a single test with all global random seeds, but actually the last commit has broken some other tests ... |
OmarManzoor
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #22827
What does this implement/fix? Explain your changes.
I added the
global_random_seedfixture to the testtest_factor_analysis.Any other comments?
I haven't submitted anything myself in a while and thought I'll annoy you a bit. 😁