Skip to content

CI Trigger wheels build on workflow_dispatch #29297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jun 19, 2024

Follow-up of #29295 to be able to upload nightly wheels when we manually trigger the workflow like I just wanted. I realised that nothing happens because the check-trigger script does not take into account the workflow_dispatch workflow and the build wheels step is skipped, see workflow

Tested on my fork (with simplified setup): https://github.com/lesteve/scikit-learn/actions/runs/9577944751

Copy link

github-actions bot commented Jun 19, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 28b0cea. Link to the linter CI: here

@lesteve lesteve changed the title CI Trigger wheels workflow on workflow_dispatch CI Trigger wheels build on workflow_dispatch Jun 19, 2024
@lesteve lesteve added the Quick Review For PRs that are quick to review label Jun 19, 2024
@lesteve lesteve force-pushed the wheels-on-workflow-dispatch branch from 451eb83 to 1fc9dd0 Compare June 19, 2024 07:58
@adrinjalali adrinjalali enabled auto-merge (squash) June 19, 2024 08:14
@adrinjalali adrinjalali merged commit 9a41238 into scikit-learn:main Jun 19, 2024
28 checks passed
@lesteve lesteve deleted the wheels-on-workflow-dispatch branch June 19, 2024 12:04
@lesteve
Copy link
Member Author

lesteve commented Jun 19, 2024

Oh well, yet another bug, triggering the workflow manually has uploaded wheels to https://anaconda.org/scikit-learn-wheels-staging/scikit-learn/files instead of https://anaconda.org/scientific-python-nightly-wheels/scikit-learn/files, please CI can you put me out of this misery 🙃?

I should have just waited until tomorrow morning but I kind of wanted some sense of achievement today, well not quite there yet 😓

@lesteve
Copy link
Member Author

lesteve commented Jun 19, 2024

All right I have opened #29298 to fix it, hopefully this is the last one 🤞

clin1234 pushed a commit to clin1234/scikit-learn that referenced this pull request Jun 19, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build / CI Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants