-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
MRG Add Warning for NaNs in Yeo-Johnson Inverse Transform with Extremely Skewed Data #29307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
1cf77b0
fix issue 28946
rnmourao cbac667
lint
rnmourao 8ee0689
Merge branch 'scikit-learn:main' into issue_28946
maf-rnmourao 26750a6
Merge branch 'main' into issue_28946
maf-rnmourao 019238c
Merge branch 'main' into issue_28946
maf-rnmourao 0d63296
Merge branch 'main' into issue_28946
maf-rnmourao 9a9b7d8
Merge branch 'main' into issue_28946
maf-rnmourao 0916652
Merge branch 'main' into issue_28946
maf-rnmourao 4919f1a
Merge branch 'main' into issue_28946
maf-rnmourao 36339e5
Merge branch 'scikit-learn:main' into issue_28946
maf-rnmourao 47037a8
Update sklearn/preprocessing/tests/test_data.py
maf-rnmourao 2cb8a3e
Update sklearn/preprocessing/tests/test_data.py
maf-rnmourao 3d1ded9
Update sklearn/preprocessing/tests/test_data.py
maf-rnmourao 5b4f6b6
Merge branch 'main' into issue_28946
maf-rnmourao 15007e2
Merge branch 'main' into issue_28946
maf-rnmourao 587eb12
refined warning message for NaNs in inverse transform
rnmourao 01f6aaf
linting fixes
rnmourao 6a98c89
linting fixes
rnmourao 2552e2a
fix whats new number
rnmourao e82d244
Merge branch 'main' into issue_28946
maf-rnmourao 2c95673
adjust the with nest logic
rnmourao c81d5fc
Merge branch 'main' into issue_28946
maf-rnmourao c039ee2
Update doc/whats_new/upcoming_changes/sklearn.preprocessing/29307.enh…
maf-rnmourao cd5d8e4
added TransformationFailedWarning; light check for Yeo-Johnson invers…
rnmourao 68dfc84
Merge branch 'main' into issue_28946
maf-rnmourao 5041cf9
replaced TransformFailedWarning with UserWarning
rnmourao 0b6de10
checking all warnings
rnmourao 5f44202
a more elegant test
rnmourao 4814802
Merge branch 'main' into issue_28946
maf-rnmourao 1875cb9
Merge branch 'main' into issue_28946
maf-rnmourao 264c4c4
Update doc/whats_new/upcoming_changes/sklearn.preprocessing/29307.enh…
maf-rnmourao 54fcae3
Update doc/whats_new/upcoming_changes/sklearn.preprocessing/29307.enh…
maf-rnmourao 519abe4
Update sklearn/preprocessing/_data.py
maf-rnmourao 18bdbea
Update sklearn/preprocessing/_data.py
maf-rnmourao fbf5798
Update sklearn/preprocessing/tests/test_data.py
maf-rnmourao 5b57c0f
Merge branch 'main' into issue_28946
maf-rnmourao 85b2484
lint fixes
rnmourao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
doc/whats_new/upcoming_changes/sklearn.preprocessing/29307.enhancement.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
- The :class:`preprocessing.PowerTransformer` now returns a warning | ||
when NaN values are encountered in the inverse transform, `inverse_transform`, typically | ||
caused by extremely skewed data. | ||
By :user:Roberto Mourao <maf-rnmourao> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maf-rnmourao the rst syntax is not quite right, would you be kind enough to open a PR with the following change 🙏:
From the dev website:

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lesteve ,
Here is the PR: #32093
Best Regards,