Skip to content

FIX missing force_writeable in KernelCenterer.transform #29328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

FIX missing force_writeable in KernelCenterer.transform #29328

merged 1 commit into from
Jun 21, 2024

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jun 21, 2024 •
edited by lesteve
Loading

Fix the CI failure on main described here: #29325 (comment) caused by the recently concurrently merged fixes in #29018 and #29100.

/cc @jeremiedbb @lesteve.

Fixes #29326
Fixes #29325
Fixes #29324
Fixes #29323

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Jun 21, 2024
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cd677b3. Link to the linter CI: here

lesteve
lesteve approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lesteve lesteve enabled auto-merge (squash) June 21, 2024 08:12
@lesteve
Copy link
Member

lesteve commented Jun 21, 2024

I enabled auto-merge, to avoid having red CIs in PRs

This was referenced Jun 21, 2024
Merged
Merged
jeremiedbb
jeremiedbb approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just to see if the new common test is useful, all planned ! 😄

@lesteve lesteve merged commit a490ab1 into scikit-learn:main Jun 21, 2024
47 checks passed
@ogrisel ogrisel deleted the fix-force_writeable-in-KernelPCA.transform branch June 21, 2024 09:11
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@ogrisel @jeremiedbb
FIX missing force_writeable in KernelCenterer.transform (scikit-learn…
ec29bd7 
…#29328)
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@ogrisel @jeremiedbb
FIX missing force_writeable in KernelCenterer.transform (scikit-learn…
3a6cf22 
…#29328)
jeremiedbb pushed a commit that referenced this pull request Jul 2, 2024
@ogrisel @jeremiedbb
FIX missing force_writeable in KernelCenterer.transform (#29328)
9e30f1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:preprocessing No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
3 participants
@ogrisel @lesteve @jeremiedbb