Skip to content

CI Use pip 24.1 in free-threaded build #29344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jun 24, 2024

pip 24.1 has been released on June 21st (see https://pypi.org/project/pip/#history) and correcly installs free-threaded wheels.

Until now, we were using a beta version 24.1b1 or 24.1b2.

The CI will be red until #29333 is fixed.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7951fc0. Link to the linter CI: here

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betatim betatim merged commit 0c751d8 into scikit-learn:main Jun 26, 2024
36 checks passed
@lesteve lesteve deleted the free-threaded-pip-24.1 branch June 26, 2024 10:48
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
@lesteve lesteve added the free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703) label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build / CI free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants