✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 4c347a6. Link to the linter CI: here}

Yeah, so that was supposed to be easy right 😅 ... this does not work currently because we are building against a numpy<2 version and we do pip install --check-build-dependencies where the build requirements in pyproject.toml wants numpy>=2. The error is:

ERROR: Some build dependencies for file:///home/vsts/work/1/s conflict with the backend dependencies: numpy==1.26.4 is incompatible with numpy>=2.0.0.

Oh well maybe a good reason to try to have another look at #28721 which would do version checks inside meson.build rather than relying on --check-build-dependencies ...

Maybe we just don't want to require building against numpy 2.

If one wants to build and run against system Numpy, why should we prevent that ?

EDIT: I'm moving this discussion back to the issue

Closing in favor of #28721