-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Update _hierarchical_fast.pyx #29368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fix bug in mst_linkage_core function initialization - Corrected initialization of new_node to handle edge cases. - Added validation to ensure the algorithm continues properly when no new node is found. Closes scikit-learn#1234
❌ Linting issuesThis PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling You can see the details of the linting issues under the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix bug in mst_linkage_core function initialization
- Corrected initialization of new_node to handle edge cases.
- Added validation to ensure the algorithm continues properly when no new node is found.
Closes #1234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewd
This would need a test to show what it's fixing. And needs to pass the linter as well. |
i will fix the linter issue could you please tell me what test case I can you |
Fix bug in mst_linkage_core function initialization
Closes #1234
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?