CI Fix Assign workflow #29408
CI Fix Assign workflow #29408
Conversation
There was a problem hiding this comment.
LGTM. Thanks for all the sleuthing to figure out what was really causing this.
Should we add a comment to remind people from the future to not use gh?
Personally I also wonder about the usefulness of assigning yourself to an issue. I'd prefer it if people either left a quick comment "I'll attempt this" or opened a (WIP) PR shortly after they start working on the issue. Those seem like perfectly good ways to avoid the problem of "two people work on the same issue". However, I wonder if the reason people like using the assignment feature has another reason?
I'd be +0 on removing the workflow to reduce our maintenance, but not +1 because I think it would increase the number of people asking to be assigned, which is also work.
|
I set auto-merge. About removing the workflow, I would be maybe +0.5 to remove it, because I don't think it is that useful, but this is probably a conversation to have in a monthly developer meeting? Also in an ideal world, we would from time to time look at issues with assignee that have not been updated in a while to reset the label "help wanted" but not really worth it in our imperfect world 🤷 |
Fix #29395
This uses the REST API rather than
ghwhich only work for scikit-learn team members, see #29395 (comment) for more details if you are really curious.I tested this on my fork see lesteve#36 and this seems to work fine.
Regression introduced in #28031 (January 2 2024), it took us 6 months to realise. My feeling is that the assign workflow is not that useful in practice but oh well 🤷