Skip to content

FIX make check_array accept sparse inputs when array api dispatch is enabled #29469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jul 11, 2024

Fixes #29452

This is a minimal fix for #29452 that only changes check_array without attempting to make get_namespace accept sparse inputs or reject them more that in already does (that is, only when array_api_dispatch=True at the time of writing).

This is an alternative to #29466.

Copy link

github-actions bot commented Jul 11, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 39760c8. Link to the linter CI: here

@ogrisel
Copy link
Member Author

ogrisel commented Jul 11, 2024

As seen in #29470, this is a very partial fix for this kind of problem. Let's not merge this PR as long as we do not find a consensus in the discussion running in the alternative #29466 PR.

@ogrisel
Copy link
Member Author

ogrisel commented Jul 29, 2024

Closing in favor of either #29466 or #29476.

@ogrisel ogrisel closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array API regression in homogeneity_completeness_v_measure?
1 participant