Investigate impact of rejecting sparse inputs in get_namespace
#29470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_namespace
This was referenced Jul 11, 2024
|
Closing since the purpose of this PR was to trigger a single CI run to identify all occurrences of this pattern in the current state of our code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to see the list of things that break if we consistently reject sparse inputs in
get_namespace(whether or notarray_api_dispatchis enabled).This is based on the minimal fix for
check_arraysubmitted independently under #29469 as an alternative to #29466. See discussion in #29466 for context.Note: I already updated
check_non_negativeas part of this PR but nottype_of_targetbecause it's much more involved.But first let's run the CI to find other cases.