Skip to content

BENCH Don't use setuptools based build commands #29500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

BENCH Don't use setuptools based build commands #29500

merged 1 commit into from
Jul 16, 2024

Conversation

jeremiedbb
Copy link
Member

Fixes #29494

It looks like the default build commands have changed since #29352, so let's write them explicitly and not rely on the default.

Also take the opportunity to bump the dependencies for numpy 2.

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: dab3737. Link to the linter CI: here

@lesteve lesteve merged commit b204dba into scikit-learn:main Jul 16, 2024
33 checks passed
@lesteve
Copy link
Member

lesteve commented Jul 16, 2024

Seems reasonable, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @lesteve @adrinjalali