CI Install pandas when testing the free threaded wheels #29572
Conversation
There was a problem hiding this comment.
From the CI run I see:
Collecting pandas
Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/pandas/3.0.0.dev0%2B1252.gd6c9941b73/pandas-3.0.0.dev0%2B1252.gd6c9941b73-cp313-cp313t-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.6 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.6/11.6 MB 50.7 MB/s eta 0:00:00
which means it is picking up cp313t correctly.
LGTM
| CIBW_BEFORE_TEST: bash {project}/build_tools/wheels/cibw_before_test.sh | ||
| CIBW_TEST_REQUIRES: pytest pandas |
There was a problem hiding this comment.
I am not sure why we need this, since the dev version of pandas is already installed in cibw_before_test.sh.
I checked the logs and this do not cause pip to override the dev wheel with the stable release wheel:
...
+ pip install pytest pandas
Collecting pytest
Downloading pytest-8.3.2-py3-none-any.whl.metadata (7.5 kB)
Requirement already satisfied: pandas in /tmp/tmp.ZWPQ7oIjQL/venv/lib/python3.13/site-packages (3.0.0.dev0+1252.gd6c9941b73)
...
There was a problem hiding this comment.
CIBW_TEST_REQUIRES is used by all the other builds though (i.e. not free-threaded ones). In other words build_tools/wheels/cibw_before_test.sh only does something (install dev pandas) for the free-threaded build for the non free-threaded builds this is a noop.
I guess doing it this way makes it easier to update when eventually when numpy, scipy and pandas have a release with a free-threaded wheel: remove CIBW_BEFORE_TEST and build_tools/wheels/cibw_before_test.sh.
This is a follow-up of #29247, in particular this comment:
Free-threaded wheels for pandas has recently been made available, according to Quansight-Labs/free-threaded-compatibility#23 (comment).