BLD Do not require meson-python when using meson directly #29578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jul 29, 2024
betatim
approved these changes
Jul 30, 2024
|
For my education, when would you not use pip/use meson directly? |
pip is definitely the 99.9% use case. Sometimes it's convenient to do meson + ninja, for example to show the full compilation commands being run as in #28603 (comment). I am sure there is a way with Edit: I ended up editing #28603 (comment) to add the way to use pip and pass |
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meson-python is used when going through pip as the build backend.
Without meson-python installed, you should be able to build just fine doing something like
This PR only checks meson-python version when it is installed, which is good enough (i.e. does not exactly differentiate between going through pip or using meson directly).