Skip to content

DOC Add plot stock market example to API docs #29602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

alexqiao
Copy link
Contributor

@alexqiao alexqiao commented Aug 1, 2024

Reference Issues/PRs

#26927

What does this implement/fix? Explain your changes.

Add plot stock market example to API docs

Any other comments?

Copy link

github-actions bot commented Aug 1, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: efb027c. Link to the linter CI: here

Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexqiao thanks for the PR. We normally link the related example to the main paragraph at the beginning of the class, just above the Read more in the User Guide phrase.

link the related example to the main paragraph at the beginning of the class, just above the Read more in the User Guide phrase
@alexqiao
Copy link
Contributor Author

alexqiao commented Aug 1, 2024

I already update the commit, please check whether it is right. Thanks.

For a usage example see
:ref:`sphx_glr_auto_examples_applications_plot_stock_market.py`


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra line still has to be removed, it is causing the linting to fail due to a blank space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I already delete . Sorry to bother~

delete the blank line
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good to go, thanks @alexqiao. Merging!

@ArturoAmorQ ArturoAmorQ enabled auto-merge (squash) August 1, 2024 15:59
@ArturoAmorQ ArturoAmorQ merged commit 9a6b7d6 into scikit-learn:main Aug 2, 2024
30 checks passed
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants