Fix seed sensitivity of test_fastica_eigh_low_rank_warning #29612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeds] test_fastica_eigh_low_rank_warning
|
Apparently this fixed the problem on Linux with MKL but not on macos with MKL... EDIT: not sure in retrospect. See the edited description of the PR. |
test_fastica_eigh_low_rank_warning
…in test [azure parallel] [all random seeds] test_fastica_simple test_fit_transform test_inverse_transform test_fastica_simple_different_solvers test_fastica_eigh_low_rank_warning
fc42de6 to
8cf7261
Compare
8cf7261 to
ae6c18b
Compare
|
Base on the CI report in 4981cbf, this fixed the sensitivity problem in the test. Note that to fix this test failure, I actually had to change the code in |
ogrisel
commented
Aug 2, 2024
ogrisel
commented
Aug 2, 2024
Self review fixes.
|
/cc @lesteve |
thomasjpfan
approved these changes
Aug 2, 2024
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally reported in #26802 and more recently in #29609.
I cannot reproduce on my local setup, so let's try via the CI triggered by this draft PR.
EDIT: the
ConvergenceWarninghappens later (in the fast ica solver itself) while the expectedUserWarningshould be raised earlier, in the whitening step, irrespective of whetherFastICAconverges or not. I therefore think that the cause of the problem is that our eps-based detection of rank deficient case is too low to be platform agnostic.Fixes #26802.