DOC clarify that n_jobs argument uses threading in pairwise_distances and pairwise_kernels #29693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Aug 22, 2024
There was a problem hiding this comment.
@stepan-srsen Thank you for the PR!
I have a minor nit, but other wise LGTM.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
lesteve
approved these changes
Aug 23, 2024
|
Merging this one thanks @stepan-srsen! |
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
… and pairwise_kernels (scikit-learn#29693) Co-authored-by: Stepan Srsen <srsen@manganese.itc.univie.ac.at> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
… and pairwise_kernels (scikit-learn#29693) Co-authored-by: Stepan Srsen <srsen@manganese.itc.univie.ac.at> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
… and pairwise_kernels (#29693) Co-authored-by: Stepan Srsen <srsen@manganese.itc.univie.ac.at> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #29587
What does this implement/fix? Explain your changes.
Improves the documentation of
pairwise_distancesandpairwise_kernelsso that it is clear that they use threading when then_jobsargument is used. One could expect the functions to be truly parallel using multiprocessing otherwise, which is not the case and that has a serial performance impact for user-defined metric functions (see #29587).