TST refactor instance generation and parameter setting #29702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
previously approved these changes
Aug 22, 2024
| ) | ||
| from sklearn.svm import SVC, SVR, LinearSVC, LinearSVR, NuSVC, NuSVR, OneClassSVM | ||
| from sklearn.tree import DecisionTreeClassifier, DecisionTreeRegressor | ||
| from sklearn.utils import all_estimators |
There was a problem hiding this comment.
I'm surprised that importing all_estimators does not cause a circular dependency.
This was referenced Aug 23, 2024
|
A few other PRs somewhat depend on this one, would be nice to move it forward. |
thomasjpfan
approved these changes
Sep 2, 2024
glemaitre
approved these changes
Sep 3, 2024
| # than `LinearRegression` if we don't fix `min_samples` parameter. | ||
| # For common test, we can enforce using `LinearRegression` that | ||
| # is the default estimator in `RANSACRegressor` instead of `Ridge`. | ||
| if issubclass(Estimator, RANSACRegressor): |
There was a problem hiding this comment.
Not in this PR because it'll go sideways but I think that we should have a small subsequent PR where we should specify as much as possible the parameter below into the TEST_PARAM and make sure that we call the _set_checking_parameters. This would be more consistent with the rest and reduce the number of places that we set parameters.
glemaitre
approved these changes
Sep 3, 2024
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
|
Enabling auto-merge. Let's try to get a new machine with another processor for the Debian build to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors instance generation out of other files, and also fixes #16311 by being explicit about which parameters to set for each estimator.
As a part of working on tests, I'm trying to keep each PR rather small for them to be easy to review.
I'm not 100% happy with the
utils/_test_common/instance_generator.pypath though.cc @glemaitre @adam2392 @thomasjpfan