-
-
Notifications
You must be signed in to change notification settings - Fork 26k
ENH add support for array API to various metric #29709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add support for array API to various metric #29709
Conversation
in _weight_boosting.py.
`ensemble/_weight_boosting.py` file, moving it below the `Examples` section for improved organization. Included an AdaBoost example reference within the DecisionTree class in the `tree/-class.py` file.
…sion Trees user guide. - Modified the doc-string wording in the `AdaBoostClassifier` class referencing to the aforementioned example.
…related to temperature scaling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment I added, this looks good.
root_mean_squared_log_error
& mean_squared_log_error
I'd like to see what @ogrisel thinks here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the following nitpicky suggestion. I will commit it and if CI goes through, it will auto-merge.
Thank you for your time! |
I realized I merged with running the CUDA CI first... Let's be hopeful... |
At least the tests pass with pytorch on MPS device, I tried locally. |
All is fine with CUDA apparently: https://github.com/scikit-learn/scikit-learn/actions/runs/11076066477/job/30778541141 |
Reference Issues/PRs
Towards #29678, #26024
What does this implement/fix? Explain your changes.
This PR updates the following functions in
sklearn.metrics
:mean_absolute_error
mean_absolute_percentage_error
mean_squared_error
root_mean_squared_error
mean_squared_log_error
root_mean_squared_log_error
Specifically:
y_true
andy_pred
are within the correct domain for the functionmultioutput=uniform_average
.Any other comments?
root_mean_squared_log_error
&mean_squared_log_error
#29686, which was closed due to re-branching.