Skip to content

DOC added links for plot_affinity_propagation.py #29759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

ivanpan0626
Copy link
Contributor

@ivanpan0626 ivanpan0626 commented Sep 1, 2024

Reference Issues/PRs

issue #26927

What does this implement/fix? Explain your changes.

Added example links for plot_affinity_propagation.py
Added example links for plot_dbscan.py

Any other comments?

Copy link

github-actions bot commented Sep 1, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0bf7b0b. Link to the linter CI: here

Copy link
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment. Otherwise LGTM.

For an example, see :ref:`examples/cluster/plot_affinity_propagation.py
<sphx_glr_auto_examples_cluster_plot_affinity_propagation.py>`.
For an example usage,
see :ref:`sphx_glr_auto_examples_cluster_plot_affinity_propagation.py`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the example, and rebased the branch.

@marenwestermann
Copy link
Member

Can you pull the changes from upstream main into your branch? It should fix the CI failures.

Copy link
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ping @adrinjalali

@adrinjalali adrinjalali enabled auto-merge (squash) October 17, 2024 10:45
@adrinjalali
Copy link
Member

@ivanpan0626 in the future please make sure you create a feature branch locally instead of working on your main branch.

@adrinjalali adrinjalali merged commit 4400917 into scikit-learn:main Oct 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants