DOC add more developer doc in RidgeGCV #29857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have a look. |
There was a problem hiding this comment.
Thank you, @glemaitre, for taking this on. I have a few suggestions.
adrinjalali
reviewed
Sep 17, 2024
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
|
I like it, thank you @glemaitre. |
adrinjalali
approved these changes
Sep 18, 2024
kbharat1210
pushed a commit
to kbharat1210/scikit-learn
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on fixing a couple of issues in
RidgeCV(eg. #29634), we find out that it is not particularly easy to understand the different code path and what is_RidgeGCVwithout going into details in the maths of the references.I'm trying to provide a higher level explanation in the docstring of
_RidgeGCVto have a quick overview of what is going on.