✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 297ceeb. Link to the linter CI: here}

@jeremiedbb or @glemaitre , requesting either give this a quick look and let me know if this pr is beneficial to the project. Goal is to deprecate affinity keyword as per the linked conversation.

Edit: Conflicts Resolved.

I went through the original issue. There is no need to change any code. The only thing that @Micky774 is mentioning is to document the fact that metric can take any valid metric when linkage="single" and connectivity=None.

So there is no need to change any code in the private functions.

I went through the original issue. There is no need to change any code. The only thing that @Micky774 is mentioning is to document the fact that metric can take any valid metric when linkage="single" and connectivity=None.

So there is no need to change any code in the private functions.

Ok I misunderstood the assignment so, I thought the keyword affinity had to be removed. Thanks, I'll change this PR into a DOC pr and alter the docs only and undo the other changes.

I thought the keyword affinity had to be removed

Indeed, it already had been removed in a prior version of scikit-learn. Since the issue is old, at this time, the parameter was only deprecate and announced to be removed. So I agree that it is pretty confusing :)

@glemaitre Ready for review. Most over the top PR for such a small change to docs !