Skip to content

DOC merge example presenting the concept of validation curve #29936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 11, 2024
Merged

DOC merge example presenting the concept of validation curve #29936

merged 20 commits into from
Oct 11, 2024

Conversation

saldanhad
Copy link
Contributor

Reference Issues/PRs

Part of #27151

What does this implement/fix? Explain your changes.

Merged Plotting Validation Curves example with the Train error vs Test error example to simplify example under model_selection.

@saldanhad saldanhad changed the title DOC: Merge train v test error with plotin validation curve example DOC: Merge train v test error with ploting validation curve example Sep 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5376ea2. Link to the linter CI: here

@ogrisel
Copy link
Member

ogrisel commented Sep 27, 2024

Could you please update the redirects variable in doc/conf.py to make sure that the deleted example redirects to the merged example?

@ogrisel
Copy link
Member

ogrisel commented Sep 27, 2024

Also, please merge an updated version of the main branch into your validationcurve branch. You can either do that locally and push the result to your GitHub fork to get the PR updated, or click the "Update branch" in the GitHub user interface (and pull then the result locally if you plan to add further commits to your local branch).

@saldanhad saldanhad marked this pull request as draft September 27, 2024 15:48
@saldanhad saldanhad marked this pull request as ready for review September 27, 2024 17:18
@saldanhad
Copy link
Contributor Author

@ogrisel, Appreciate your help on this. Changes suggested are implemented and is now ready for review. Thank you!

@saldanhad saldanhad marked this pull request as draft September 28, 2024 10:09
@saldanhad
Copy link
Contributor Author

Hi @ogrisel, Since we are merging the train vs test error with validation curves, do you think it would be good to have the navigation link as Train vs Test error and Validation Curves or is it better as is?

@saldanhad saldanhad marked this pull request as ready for review September 28, 2024 20:36
@glemaitre glemaitre self-requested a review September 29, 2024 16:38
glemaitre
glemaitre reviewed Sep 29, 2024
View reviewed changes
@glemaitre glemaitre changed the title DOC: Merge train v test error with ploting validation curve example DOC merge example presenting the concept of validation curve Sep 29, 2024
@saldanhad saldanhad requested a review from glemaitre October 1, 2024 21:17
@saldanhad
Copy link
Contributor Author

RFR @glemaitre

glemaitre
glemaitre approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit that:

  • improve the entire narration
  • change the model parameters to better show the trade-off underfit/overfit

I'll wait for the CI to check the rendering.

@glemaitre glemaitre enabled auto-merge (squash) October 11, 2024 16:20
@glemaitre glemaitre merged commit 0b5f812 into scikit-learn:main Oct 11, 2024
28 checks passed
@saldanhad saldanhad deleted the validationcurve branch October 12, 2024 11:46
@Charlie-XIAO Charlie-XIAO mentioned this pull request Oct 13, 2024
Closed
@glemaitre glemaitre mentioned this pull request Oct 13, 2024
Merged
@StefanieSenger StefanieSenger mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel left review comments

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
Documentation improvement
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saldanhad @ogrisel @glemaitre