Skip to content

DOC: make it explicit that groups is used to perform the split in GridSearch CV #29939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

victoris93
Copy link
Contributor

Closes #29917
Added a clarification about groups in GridSearchCV.fit(X, y, groups=groups): the arg determines how the dataset is split.

@victoris93 victoris93 changed the title DOX: make it explicit that groups is used to perform the split in GridSearch CV DOC: make it explicit that groups is used to perform the split in GridSearch CV Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2df2093. Link to the linter CI: here

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks very much.

@victoris93
Copy link
Contributor Author

@ogrisel made the changes but divided the last sentence in two for legibility if that's ok

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogrisel ogrisel merged commit 783d72f into scikit-learn:main Sep 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

**params documentation for GridSearchCV.fit is ambiguous
2 participants