MAINT Avoid RuntimeWarning about invalid value in cast #29977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29929.
I implemented my suggestion in #29929 (comment) and added a simple unit test.
The unit test seems to fail on
main
consistently. Note that this relies on the values ofnp.empty
so this is not fully deterministic but on my machine it seems like the following snippet consistently produces a warning:A more realistic snippet that gives the warning is below. On my machine this produces a RuntimeWarning roughly 3-4 times out of 10 but takes a lot longer than the unit test (each run takes maybe ~2 seconds).