Skip to content

MAINT|API Clean up deprecations for 1.6: SAMME.R in AdaBoost and deprecate algorithm #29997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Oct 3, 2024

Removed deprecated SAMME.R option of algorithm in AdaBoostClassifier and deprecated the algorithm param since there's now only 1 single valid option.

cc/ @glemaitre, cf #26784 (comment)

Copy link

github-actions bot commented Oct 3, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5f05428. Link to the linter CI: here

@glemaitre glemaitre self-requested a review October 8, 2024 18:23
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre
Copy link
Member

Enabling auto-merge.

Thanks @jeremiedbb

@glemaitre glemaitre merged commit 6de55b3 into scikit-learn:main Oct 8, 2024
30 checks passed
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
…ecate algorithm (scikit-learn#29997)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants