-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Remove mention of deprecated multi_class
in LogisticRegression
#29998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inline with the changes since we can already advocate to use OneVsRestClassifier
instead of the parameter. I find it complementary to the deprecation warning.
doc/modules/linear_model.rst
Outdated
@@ -1000,6 +1000,8 @@ logistic regression, see also `log-linear model | |||
| `ElasticNet` | :math:`\frac{1 - \rho}{2}\|W\|_F^2 + \rho \|W\|_{1,1}` | | |||
+----------------+----------------------------------------------------------------------------------+ | |||
|
|||
.. _Logistic_regression_solvers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe drop the capital letter if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I agree its weird with the capital. I initially thought I should copy what was used as reference header for logistic regression main section:
scikit-learn/doc/modules/linear_model.rst
Line 852 in 8d01acf
.. _Logistic_regression: |
@@ -827,6 +821,11 @@ class LogisticRegression(LinearClassifierMixin, SparseCoefMixin, BaseEstimator): | |||
the L2 penalty. The Elastic-Net regularization is only supported by the | |||
'saga' solver. | |||
|
|||
For :term:`multiclass` problems, only 'newton-cg', 'sag', 'saga' and 'lbfgs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremiedbb Since we are in the long summary and we have an alternative to use OvR, I would advocate from now on to use OneVsRestClassifier
. It looks legit to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright then :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once guillaume's comment is resolved
Thanks @lucyleeow LGTM. |
Reference Issues/PRs
multi_class
deprecated in #28703What does this implement/fix? Explain your changes.
multi_class
inLogisticRegression
. Also moves the section on multiclass down, as it seems to make sense to introduce the class first.Any other comments?