Skip to content

DOC Add link to FeatureAgglomeration examples in docstrings #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

AyGeeEm
Copy link
Contributor

@AyGeeEm AyGeeEm commented Oct 6, 2024

Reference Issues/PRs

References #26927

What does this implement/fix? Explain your changes.

Adds link in cluster/_agglomerative.py to example file examples/cluster/plot_feature_agglomeration_vs_univariate_selection.py. This example clarifies the usage and comparison of two different dimensionality reduction techniques, univariate feature selection and feature agglomeration.

Any other comments?

Appreciate any feedback!

Copy link

github-actions bot commented Oct 6, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6a04aab. Link to the linter CI: here

@glemaitre glemaitre self-requested a review October 8, 2024 15:58
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a small change.

I'll check how the results render and I'll merge this PR.

@glemaitre
Copy link
Member

Thanks @AyGeeEm

@glemaitre glemaitre enabled auto-merge (squash) October 8, 2024 16:54
@glemaitre glemaitre merged commit b5131b4 into scikit-learn:main Oct 8, 2024
28 checks passed
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
…earn#30014)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants