Skip to content

DOC rework the example presenting the regularization path of Lasso, Lasso-LARS, and Elastic Net #30028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

virchan
Copy link
Member

@virchan virchan commented Oct 7, 2024

Reference Issues/PRs

Fixes #29963, also towards #27151.

What does this implement/fix? Explain your changes.

This PR reworks the example of Lasso, Lasso-LARS, and Elastic Net regularization paths as presented here: URL.

Additionally, It groups the following examples together:

Any other comments?

cc: @glemaitre

Copy link

github-actions bot commented Oct 7, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8667b58. Link to the linter CI: here

@glemaitre
Copy link
Member

Could introduce the narrative within the code and get a notebook-like example. You can see this example for such format: https://github.com/scikit-learn/scikit-learn/blob/main/examples/inspection/plot_linear_model_coefficient_interpretation.py which would give the following rendering: https://scikit-learn.org/dev/auto_examples/inspection/plot_linear_model_coefficient_interpretation.html#sphx-glr-auto-examples-inspection-plot-linear-model-coefficient-interpretation-py

@virchan
Copy link
Member Author

virchan commented Oct 8, 2024

Could introduce the narrative within the code and get a notebook-like example. You can see this example for such format: https://github.com/scikit-learn/scikit-learn/blob/main/examples/inspection/plot_linear_model_coefficient_interpretation.py which would give the following rendering: https://scikit-learn.org/dev/auto_examples/inspection/plot_linear_model_coefficient_interpretation.html#sphx-glr-auto-examples-inspection-plot-linear-model-coefficient-interpretation-py

I've integrated the notebook style into the example, and it’s ready for review.

Thank you for the references!

@virchan virchan marked this pull request as ready for review October 8, 2024 00:15
@glemaitre glemaitre self-requested a review November 25, 2024 13:32
Copy link
Member Author

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating this PR to accomodate #27151.

My plan is to group regularization of linear and logistic regression into the same place. Specifically, I intend to combine:

with plot_lasso_lasso_lars_elasticnet_path.py.

Copy link
Member Author

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I grouped the following examples together to consolidate the discussion on linear and logistic regression regularization in one place:

I also updated the example links accordingly.

Let me know if I missed anything—I'd be happy to make further adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC rework the example presenting the regularization path of Lasso, Lasso-LARS, and Elastic Net
2 participants