Skip to content

MAINT fix references to sample_weight meta-issue in comments #30061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

MAINT fix references to sample_weight meta-issue in comments #30061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sklearn/cluster/_kmeans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,7 @@ def score(self, X, y=None, sample_weight=None):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/ensemble/_bagging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ def _get_estimator(self):
def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.input_tags.allow_nan = get_tags(self._get_estimator()).input_tags.allow_nan
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
6 changes: 3 additions & 3 deletions sklearn/ensemble/_forest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,7 @@ def __init__(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -1931,7 +1931,7 @@ def __init__(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -3016,7 +3016,7 @@ def transform(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
4 changes: 2 additions & 2 deletions sklearn/ensemble/_gb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,7 @@ def staged_predict_proba(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: investigate failure see meta-issue #162298
# TODO: investigate failure see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -2194,7 +2194,7 @@ def apply(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: investigate failure see meta-issue #162298
# TODO: investigate failure see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,7 +1389,7 @@ def _compute_partial_dependence_recursion(self, grid, target_features):
def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.input_tags.allow_nan = True
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/ensemble/_iforest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ def _compute_score_samples(self, X, subsample_features):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
4 changes: 2 additions & 2 deletions sklearn/ensemble/_weight_boosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ def predict_log_proba(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -1179,7 +1179,7 @@ def staged_predict(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/linear_model/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ def rmatvec(b):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: investigate failure see meta-issue #162298
# TODO: investigate failure see meta-issue #16298
#
# Note: this model should converge to the minimum norm solution of the
# least squares problem and as result be numerically stable enough when
Expand Down
2 changes: 1 addition & 1 deletion sklearn/linear_model/_bayes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def _log_marginal_likelihood(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: fix sample_weight handling of this estimator, see meta-issue #162298
# TODO: fix sample_weight handling of this estimator, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/linear_model/_perceptron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def __init__(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/linear_model/_ransac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ def get_metadata_routing(self):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
6 changes: 3 additions & 3 deletions sklearn/linear_model/_stochastic_gradient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,7 +1376,7 @@ def predict_log_proba(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -2061,7 +2061,7 @@ def __init__(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -2642,7 +2642,7 @@ def predict(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/naive_bayes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ def partial_fit(self, X, y, classes=None, sample_weight=None):
def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.input_tags.positive_only = True
# TODO: fix sample_weight handling of this estimator, see meta-issue #162298
# TODO: fix sample_weight handling of this estimator, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
2 changes: 1 addition & 1 deletion sklearn/preprocessing/_discretization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ def get_feature_names_out(self, input_features=None):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: fix sample_weight handling of this estimator, see meta-issue #162298
# TODO: fix sample_weight handling of this estimator, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
14 changes: 7 additions & 7 deletions sklearn/svm/_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def fit(self, X, y, sample_weight=None):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test when _dual=True, see meta-issue #162298
# TODO: replace by a statistical test when _dual=True, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -615,7 +615,7 @@ def fit(self, X, y, sample_weight=None):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: replace by a statistical test, see meta-issue #162298
# TODO: replace by a statistical test, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -900,7 +900,7 @@ def __sklearn_tags__(self):
tags._xfail_checks = {
# TODO: fix sample_weight handling of this estimator when probability=False
# TODO: replace by a statistical test when probability=True
# see meta-issue #162298
# see meta-issue #16298
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
),
Expand Down Expand Up @@ -1177,7 +1177,7 @@ def __sklearn_tags__(self):
"check_class_weight_classifiers": "class_weight is ignored.",
# TODO: fix sample_weight handling of this estimator when probability=False
# TODO: replace by a statistical test when probability=True
# see meta-issue #162298
# see meta-issue #16298
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
),
Expand Down Expand Up @@ -1381,7 +1381,7 @@ def __init__(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: fix sample_weight handling of this estimator, see meta-issue #162298
# TODO: fix sample_weight handling of this estimator, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -1576,7 +1576,7 @@ def __init__(

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: fix sample_weight handling of this estimator, see meta-issue #162298
# TODO: fix sample_weight handling of this estimator, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down Expand Up @@ -1840,7 +1840,7 @@ def predict(self, X):

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
# TODO: fix sample_weight handling of this estimator, see meta-issue #162298
# TODO: fix sample_weight handling of this estimator, see meta-issue #16298
tags._xfail_checks = {
"check_sample_weight_equivalence": (
"sample_weight is not equivalent to removing/repeating samples."
Expand Down
Loading