Skip to content

Fix cibuildwheel for macos #30069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix cibuildwheel for macos #30069

merged 3 commits into from
Oct 15, 2024

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Oct 15, 2024 •
edited by lesteve
Loading

Reference Issues/PRs

Fix #30071, follow-up of #30060.

macOS 13 and 14 do not ship with conda anymore. We have to install it first to use it in the wheel builder.

What does this implement/fix? Explain your changes.

This PR uses conda-incubator/setup-miniconda@v3 to install conda first before cibuildwheel runs for macos.

@thomasjpfan thomasjpfan mentioned this pull request Oct 15, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 81d51da. Link to the linter CI: here

@thomasjpfan thomasjpfan changed the title Fix cibuildwheel for arm64 linux Fix cibuildwheel for macos Oct 15, 2024
@adrinjalali
Copy link
Member

This is mostly okay, except that conda-incubator seems to have an issue:

Post job cleanup.
Removing uncompressed packages to trim down cache folder...
  Removing "/Users/runner/conda_pkgs_dir/llvm-openmp-11.1.0-hf3c4609_1"
  Remove failed, moving "/Users/runner/conda_pkgs_dir/llvm-openmp-11.1.0-hf3c4609_1" to temp folder
  Error: EACCES: permission denied, rename '/Users/runner/conda_pkgs_dir/llvm-openmp-11.1.0-hf3c4609_1' -> '/var/folders/t_/mmhnh941511_hp2lwh383bp00000gn/T/llvm-openmp-11.1.0-hf3c4609_1'

@ogrisel
Copy link
Member

ogrisel commented Oct 15, 2024

I think I identified the cause of the problem. Let me try to push a quick fix.

ogrisel
ogrisel approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the build is green with the latest fix.

@ogrisel ogrisel enabled auto-merge (squash) October 15, 2024 08:13
@ogrisel ogrisel merged commit e53407e into scikit-learn:main Oct 15, 2024
52 checks passed
@lesteve lesteve mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Wheel builder (last failure: Oct 15, 2024) ⚠️
3 participants
@thomasjpfan @adrinjalali @ogrisel