-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
TST use global_random_seed in sklearn/utils/tests/test_optimize.py #30112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeremiedbb
merged 14 commits into
scikit-learn:main
from
marenwestermann:grs-test-optimize
Apr 10, 2025
+9
−5
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b71abdc
Update test_optimize.py
sply88 3027c5c
Merge branch 'main' into global-random-seed-in-test_optimize
sply88 cf203a8
Merge branch 'main' into global-random-seed-in-test_optimize
sply88 f92a14c
Merge branch 'main' into global-random-seed-in-test_optimize
sply88 c037109
Merge branch 'main' into global-random-seed-in-test_optimize
sply88 5e2322a
Merge branch 'main' into global-random-seed-in-test_optimize
sply88 835be14
Merge branch 'main' into global-random-seed-in-test_optimize
sply88 077d3dc
Empty commit [all random seeds]
sply88 fe43a9e
Merge remote-tracking branch 'upstream/main' into grs-test-optimize
marenwestermann 86dd370
reduce tol [all random seeds] test_newton_cg
marenwestermann 6dcbd55
Merge remote-tracking branch 'upstream/main' into pr/marenwestermann/…
jeremiedbb 52ccc37
[all random seeds]
jeremiedbb bf156f9
lint [all random seeds]
jeremiedbb 6653bbe
Merge branch 'main' into grs-test-optimize
jeremiedbb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a tolerance of 1e-10 I had two test failures. I was able to resolve these by reducing the threshold to 1e-7. It's not an optimal solution but the default of
tol
is 1e-4. So I think this solution should be acceptable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's an okay solution. Both functions don't have the same parameters so it's hard to find the right combination such that they have the same behavior.
I replaced with
assert_allclose
and added a comment to add a bit more explanation.