-
-
Notifications
You must be signed in to change notification settings - Fork 26.1k
doc-fix: Fix for text outside of the dropdown and a grammar fix #30116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I see multiple CI jobs failing. Is there a linting command that I should be using? |
The doc failure probably comes from a warning turned into error during the build, from build log:
Maybe you need to align vertically your bullet point 2. content? You can draw some inspiration from the "Spectral Embedding" section which has a similar dropdown. You can also build the documentation locally, see doc for more details, and check the rendering. |
Made some fixes. Looks like the CI is stuck or disappeared? |
doc/modules/manifold.rst
Outdated
:math:`O[D N k^3] + O[N d^6]`. The first term reflects a similar | ||
cost to that of standard LLE. The second term comes from a QR | ||
decomposition of the local hessian estimator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc CI is still red as far as I can see, maybe try this (one more space so that **Weight Matrix
aligns vertically with the following lines that belong to the same bullet point)?
:math:`O[D N k^3] + O[N d^6]`. The first term reflects a similar | |
cost to that of standard LLE. The second term comes from a QR | |
decomposition of the local hessian estimator. | |
:math:`O[D N k^3] + O[N d^6]`. The first term reflects a similar | |
cost to that of standard LLE. The second term comes from a QR | |
decomposition of the local hessian estimator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI was showing me a big circle for a very long time. And most of the icons were blurred for some reason. Made fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the doc CI is happy now and the rendering looks good, see generated doc.
I have set auto-merge.
What does this implement/fix? Explain your changes.
Fixes the
Complexity
dropdown insideHessian Eigenmapping
section insideManifold Learning
module insideUnsupervised Learning
chapter.Currently the dropdown inside the hessian
2.2.5. Hessian Eigenmapping
doesn't have the text as attached below.https://scikit-learn.org/stable/modules/manifold.html#hessian-eigenmapping
Added a grammar fix as well.