Skip to content

Plot kmeans plusplus #30126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Conversation

natmokval
Copy link
Contributor

original PR natmokval#1

Towards #26927

added links to examples in the docstrings and the user guide for K-Means ++.

Copy link

github-actions bot commented Oct 21, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 00d67dc. Link to the linter CI: here

@marenwestermann marenwestermann self-requested a review October 23, 2024 07:57
Copy link
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

@@ -241,6 +241,9 @@ to the dataset :math:`X`.
* :ref:`sphx_glr_auto_examples_text_plot_document_clustering.py`: Document clustering
using :class:`KMeans` and :class:`MiniBatchKMeans` based on sparse data

* :ref:`sphx_glr_auto_examples_cluster_plot_kmeans_plusplus.py`: Using K-means++
to select seeds for other clustering algorithms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in this line is not correct (which causes the CI to fail).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping me. I corrected the indentation, now the CI is green.

Copy link
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
ping @adrinjalali

@adrinjalali adrinjalali merged commit 087d8b7 into scikit-learn:main Oct 29, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants