ENH Reduce redundancy in floating type checks for Array API support in _regression.py
#30128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Oct 22, 2024
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
virchan
commented
Oct 22, 2024
adrinjalali
approved these changes
Oct 22, 2024
|
cc @ogrisel |
ogrisel
approved these changes
Oct 23, 2024
ogrisel
reviewed
Oct 24, 2024
|
Actually, I do not have the permission to accept my own suggestions or to directly push to your branch. So please review and accept the suggestions first. Could you also please rename the |
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…_with_floating_dtype`.
I've made the changes. Please let me know if there’s anything else you'd like me to update! |
betatim
reviewed
Nov 1, 2024
betatim
reviewed
Nov 1, 2024
betatim
reviewed
Nov 1, 2024
betatim
reviewed
Nov 1, 2024
betatim
reviewed
Nov 1, 2024
…ype` doc-strings.
…weight`'s data-type.
OmarManzoor
approved these changes
Dec 2, 2024
|
Thank you everyone for your time! |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 4, 2024
…n `_regression.py` (scikit-learn#30128) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb
pushed a commit
that referenced
this pull request
Dec 6, 2024
…n `_regression.py` (#30128) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
virchan
added a commit
to virchan/scikit-learn
that referenced
this pull request
Dec 9, 2024
…n `_regression.py` (scikit-learn#30128) Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #30106, and unpauses #29978.
What does this implement/fix? Explain your changes.
This PR introduces a new function,
_check_reg_targets_and_floating_dtype, to streamline the floating type checks in_regression.py.The new function integrates the
_find_matching_floating_dtypelogic directly into the_check_reg_targetsfunction, and has the following signature:To inspect the resulting floating-point data type, users can access the
.dtypeattribute of the returned arrays, e.g.,y_true.dtypeory_pred.dtype.Additionally, it passes
xpto avoid redundant namespace inspection, extending the work done in #30092.The following regression metrics remain unchanged by this PR:
mean_pinball_loss(covered by ENH add support for Array API tomean_pinball_lossandexplained_variance_score#29978)root_mean_squared_error(not applicable)median_absolute_error(dependent onpercentileor_weighted_percentile)explained_variance_score(covered by ENH add support for Array API tomean_pinball_lossandexplained_variance_score#29978)max_error(not applicable)_mean_tweedie_deviance(not applicable)mean_poisson_deviance(not applicable)mean_gamma_deviance(not applicable)d2_pinball_score(dependent onpercentileor_weighted_percentile)d2_absolute_error_score(dependent onpercentileor_weighted_percentile)Any other comments?
This is part of the Array API project (#26024).
Ping: @ogrisel
Cc: @adrinjalali, @betatim, @glemaitre, @sqali.