Skip to content

MAINT Add notes-towncrier.rst to .gitignore #30153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Oct 25, 2024

The current idea is that doc/whats_new/notes-towncrier.rst is used as a temporary file whose content is manually edited and copied to v1.6.rst. We'll see in the future if this changes.

towncrier build --version 1.6 git adds notes-towncrier.rst which is annoying. Adding it to .gitignore which is what numpy is also doing.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Oct 25, 2024
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 88ba6d2. Link to the linter CI: here

@ogrisel ogrisel merged commit b9a7496 into scikit-learn:main Oct 29, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants