DOC add link plot_inductive_clustering #30182
Conversation
|
@virchan I've create a new PR and now everything seems on track |
There was a problem hiding this comment.
Thank you for the follow-up @claudio1975! I have one more suggestion.
doc/modules/clustering.rst
Outdated
| * :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`: A practical | ||
| example of inductive clustering model. |
There was a problem hiding this comment.
| * :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`: A practical | |
| example of inductive clustering model. | |
| * :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`: An example | |
| of an inductive clustering model for handling new data. |
There was a problem hiding this comment.
ok it's fine for me @virchan to commit your suggetion, but before to do it, could you add the indentation to the second line, please?
Co-authored-by: Virgil Chan <virchan.math@gmail.com>
There was a problem hiding this comment.
LGTM! I'd like to ping @marenwestermann for a quick look to help avoid any potential conflicts with PR #30127, as both involve changes to the doc/modules/clustering.rst file.
Also cc'ing @adrinjalali.
There was a problem hiding this comment.
LGTM. But yes, let's wait until #30127 is merged. The changes can then be pulled into this branch which should cause a merge conflict. After resolving it, this PR can be merged.
I think it's ok to not link this example in the docstrings of AgglomerativeClustering and RandomForestClassifier because this example is about showing the principle of inductive clustering and not about the estimators.
What does this implement/fix? Explain your changes.
Added link plot_inductive_clustering towards -#26927. It follows previous PR #30158