FIX proper inheritance for SGDOneClassSVM #30227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Nov 5, 2024
When adding the non-regression test, I had exactly this thought :). If we would have a fine grade test suite, we could have a categories for the estimators inheriting from our mixin and base estimator. Basically, even third-party will need this order of inheritance. |
adrinjalali
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
mainThis pull request addresses an issue with the
SGDOneClassSVMclass in thesklearn.linear_modelmodule, ensuring it correctly inherits fromOutlierMixinand sets the appropriate tags. The most important changes include modifying the class inheritance, updating the documentation, and adding a new test to verify the correct estimator type.