Skip to content

ENH add from_cv_results in RocCurveDisplay (single RocCurveDisplay) #30399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 72 commits into
base: main
Choose a base branch
from
+1,573 −135
Open

ENH add from_cv_results in RocCurveDisplay (single RocCurveDisplay) #30399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
a1442e5
first commit
lucyleeow Dec 3, 2024
f4f9a98
lint
lucyleeow Dec 3, 2024
9e87e13
fixes
lucyleeow Dec 18, 2024
f0908e1
factorize
lucyleeow Dec 31, 2024
7e77d4c
fix
lucyleeow Dec 31, 2024
1a4a2f3
review changes
lucyleeow Jan 15, 2025
4e25ffc
merge main
lucyleeow Jan 15, 2025
042c0f6
lint
lucyleeow Jan 15, 2025
e8a5073
ignore mypy
lucyleeow Jan 15, 2025
4431c55
fix validate plot param
lucyleeow Jan 15, 2025
34d8051
fix from predictions
lucyleeow Jan 15, 2025
dc6adce
fix example in docstring
lucyleeow Jan 15, 2025
bdf2e43
fix tests
lucyleeow Jan 15, 2025
f5dbb1d
fix docstring example
lucyleeow Jan 15, 2025
144fd13
black
lucyleeow Jan 15, 2025
0aa7751
black
lucyleeow Jan 15, 2025
70f0127
fix tests
lucyleeow Jan 15, 2025
b9e1b0b
fix testst
lucyleeow Jan 15, 2025
73984e3
fix tests
lucyleeow Jan 15, 2025
d0926f6
lint
lucyleeow Jan 16, 2025
819d6fe
fix docstring
lucyleeow Jan 16, 2025
0c31890
Merge branch 'main' into cv_results3
lucyleeow Jan 16, 2025
8b500d8
add whats new
lucyleeow Jan 16, 2025
e7244d6
amend current test
lucyleeow Jan 16, 2025
bbfc1aa
lint
lucyleeow Jan 16, 2025
65f3d21
lint
lucyleeow Jan 16, 2025
47f6bc7
review
lucyleeow Jan 21, 2025
231eb51
review
lucyleeow Jan 23, 2025
8bb0402
Merge branch 'main' into cv_results3
lucyleeow Feb 13, 2025
8fc20e8
revert to singular only
lucyleeow Feb 13, 2025
18b2b1a
lint
lucyleeow Feb 13, 2025
a1824b9
update tests, more fixes
lucyleeow Feb 13, 2025
2745405
process attrs in plot
lucyleeow Feb 17, 2025
62c3f32
add ref
lucyleeow Feb 18, 2025
c17370c
Merge branch 'main' into cv_results3
lucyleeow Feb 27, 2025
25065a0
review and add tests
lucyleeow Mar 7, 2025
d399071
review and fix tests
lucyleeow Mar 7, 2025
126dfb9
comment
lucyleeow Mar 7, 2025
e1cd3ee
merge main
lucyleeow Mar 19, 2025
412c313
review and add tests
lucyleeow Mar 19, 2025
d3af77c
add aggregate legend
lucyleeow Mar 25, 2025
d221580
amend condition
lucyleeow Mar 26, 2025
b9852ef
Merge branch 'main' into cv_results3
lucyleeow Apr 2, 2025
be649de
review
lucyleeow Apr 2, 2025
e1f455b
wip remove agg params
lucyleeow Apr 3, 2025
81e00d9
iter remove aggre param
lucyleeow Apr 4, 2025
9ee37e2
remove agg, tests pass
lucyleeow Apr 4, 2025
5577b8b
rm old param
lucyleeow Apr 9, 2025
001e00e
guillaume review
lucyleeow Apr 11, 2025
8ec3659
validate only in plot
lucyleeow Apr 11, 2025
cda0296
name change to curve_kwargs
lucyleeow Apr 11, 2025
3cc2cee
pass curve_kwarg properly and order in docstring
lucyleeow Apr 11, 2025
f71e6c7
fix naming
lucyleeow Apr 11, 2025
b171f1a
add kwarg dep test
lucyleeow Apr 11, 2025
436985b
guillaume review
lucyleeow Apr 11, 2025
0a25f17
fix test
lucyleeow Apr 11, 2025
345ed9c
format
lucyleeow Apr 11, 2025
f230ba2
format
lucyleeow Apr 11, 2025
a378188
format
lucyleeow Apr 11, 2025
1769887
format
lucyleeow Apr 12, 2025
be57690
revert **kwargs
lucyleeow Apr 12, 2025
54f2fab
merge main
lucyleeow Apr 14, 2025
c57debb
add tests codecov
lucyleeow Apr 14, 2025
d8f11a5
add _BinaryClassifierCurveDisplayMixin tests
lucyleeow Apr 14, 2025
77511e2
typo
lucyleeow Apr 14, 2025
1c9c67c
change to feature
lucyleeow Apr 14, 2025
4b82ba3
remove early param validation
lucyleeow Apr 17, 2025
11ab458
Merge branch 'main' into cv_results3
lucyleeow Apr 17, 2025
d6c1d9f
lint
lucyleeow Apr 17, 2025
08ee9d6
Merge branch 'main' into cv_results3
lucyleeow Apr 23, 2025
df177ab
review
lucyleeow Apr 24, 2025
2de0f78
add multi test
lucyleeow Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/whats_new/upcoming_changes/sklearn.metrics/30399.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Add class method `from_cv_results` to :class:`metrics.RocCurveDisplay`, which allows
easy plotting of multiple ROC curves from :func:`model_selection.cross_validate`
results.
By :user:`Lucy Liu <lucyleeow>`
Loading
Loading