Skip to content

ENH Add parameters V, VI, p, w to AgglomerativeClustering #30528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SuccessMoses
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR partially fixes #26961. These parameters are passed to the DistanceMetric.get_metric method so that "seuclidean" and "mahalanobis" metrics work with linkage = "single".

Any other comments?

When linkage != "single", scipy.cluster.hierachy.linkage is used. This method does not request for additional parameters like V for seuclidean.

Copy link

github-actions bot commented Dec 22, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8c88347. Link to the linter CI: here

@SuccessMoses
Copy link
Contributor Author

Hi @Micky774, can you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agglomerative clustering training error for seuclidean/mahalanobis affinity and single linkage
1 participant