Skip to content

TST remove xfail marker for check_sample_weight_equivalence_on_dense_data and LinearRegression #30535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Dec 23, 2024

This was fixed in #30040 for positive=False and passes for positive=True.

The sparse case is being concurrently handled in #30131 and the linked PR #30521.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e036616. Link to the linter CI: here

Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmarManzoor OmarManzoor merged commit 970503f into scikit-learn:main Dec 24, 2024
38 checks passed
@ogrisel ogrisel deleted the remove-xfail-for-check_sample_weight_equivalence_on_dense_data-on-LinearRegression branch December 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants